CodeNarc Report: Sample Project

Summary

Package	Total Files	Files with Violations	Priority 1	Priority 2	Priority 3
All Packages	419	58	-	78	36
<Root>	9	3	-	-	12
basic	45	-	-	-	-
braces	4	-	-	-	-
comments	19	13	-	-	15
concurrency	27	-	-	-	-
convention	29	1	-	-	1
design	26	3	-	1	2
dry	4	-	-	-	-
enhanced	1	1	-	-	1
exceptions	20	-	-	-	-
formatting	38	15	-	26	3
generic	11	2	-	3	-
grails	12	2	-	3	-
groovyism	33	3	-	18	-
imports	7	1	-	1	-
jdbc	6	-	-	-	-
junit	26	-	-	-	-
logging	8	-	-	-	-
naming	16	1	-	1	-
security	10	-	-	-	-
serialization	4	-	-	-	-
size	9	2	-	-	2
unnecessary	46	6	-	14	-
unused	9	5	-	11	-

Package: <Root>

➥ AbstractAstVisitorRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryObjectReferences	3	185	[SRC]rule.doNotApplyToClassNames = 'Xxx' // doNotApply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	188	[SRC]rule.applyToClassNames = 'Xxx' // apply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	189	[SRC]rule.doNotApplyToClassNames = 'Xxx' // doNotApply = NO [MSG]The code could be more concise by using a with() or identity() block

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryObjectReferences

3

185

[SRC]rule.doNotApplyToClassNames = 'Xxx' // doNotApply = NO

[MSG]The code could be more concise by using a with() or identity() block

UnnecessaryObjectReferences

3

188

[SRC]rule.applyToClassNames = 'Xxx' // apply = NO

[MSG]The code could be more concise by using a with() or identity() block

UnnecessaryObjectReferences

3

189

[SRC]rule.doNotApplyToClassNames = 'Xxx' // doNotApply = NO

[MSG]The code could be more concise by using a with() or identity() block

➥ AbstractRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryObjectReferences	3	137	[SRC]rule.doNotApplyToFilesMatching = NO_MATCH // doNotApply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	140	[SRC]rule.applyToFilesMatching = NO_MATCH // apply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	141	[SRC]rule.doNotApplyToFilesMatching = NO_MATCH // doNotApply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	177	[SRC]rule.applyToFileNames = 'org/codenarc/MyOtherTest.groovy' [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	225	[SRC]rule.doNotApplyToFileNames = 'Xxx.groovy' // doNotApply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	228	[SRC]rule.applyToFileNames = 'Xxx.groovy' // apply = NO [MSG]The code could be more concise by using a with() or identity() block
UnnecessaryObjectReferences	3	229	[SRC]rule.doNotApplyToFileNames = 'Xxx.groovy' // doNotApply = NO [MSG]The code could be more concise by using a with() or identity() block

➥ InlineViolationsParserTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MisorderedStaticImports	3	20	[SRC]import static org.codenarc.rule.InlineViolationsParser.inlineViolation [MSG]Static imports should appear before normal imports
UnnecessaryReturnKeyword	3	199	[SRC]return [lineNumber: lineNumber, sourceLineText: sourceLi..messageText] [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

MisorderedStaticImports

3

20

[SRC]import static org.codenarc.rule.InlineViolationsParser.inlineViolation

[MSG]Static imports should appear before normal imports

UnnecessaryReturnKeyword

3

199

[SRC]return [lineNumber: lineNumber, sourceLineText: sourceLi..messageText]

[MSG]The return keyword is not needed and can be removed

Package: comments

➥ AbstractJavadocEmptyTagRuleTestCase.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	53	[SRC]return rule.name [MSG]The return keyword is not needed and can be removed
UnnecessaryReturnKeyword	3	56	[SRC]return "The javadoc ${getTag()} tag is empty" [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

53

[SRC]return rule.name

[MSG]The return keyword is not needed and can be removed

UnnecessaryReturnKeyword

3

56

[SRC]return "The javadoc ${getTag()} tag is empty"

[MSG]The return keyword is not needed and can be removed

➥ AbstractJavadocMissingDescriptionRuleTestCase.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	51	[SRC]return rule.name [MSG]The return keyword is not needed and can be removed
UnnecessaryReturnKeyword	3	54	[SRC]return "The description for the javadoc ${getTag()} tag is missing" [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

51

[SRC]return rule.name

[MSG]The return keyword is not needed and can be removed

UnnecessaryReturnKeyword

3

54

[SRC]return "The description for the javadoc ${getTag()} tag is missing"

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptyAuthorTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@author' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@author'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptyExceptionTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@exception' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@exception'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptyParamTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@param' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@param'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptyReturnTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@return' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@return'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptySeeTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@see' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@see'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptySinceTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@since' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@since'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptyThrowsTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@throws' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@throws'

[MSG]The return keyword is not needed and can be removed

➥ JavadocEmptyVersionTagRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@version' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@version'

[MSG]The return keyword is not needed and can be removed

➥ JavadocMissingExceptionDescriptionRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@exception' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@exception'

[MSG]The return keyword is not needed and can be removed

➥ JavadocMissingParamDescriptionRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@param' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@param'

[MSG]The return keyword is not needed and can be removed

➥ JavadocMissingThrowsDescriptionRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	27	[SRC]return '@throws' [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

27

[SRC]return '@throws'

[MSG]The return keyword is not needed and can be removed

Package: convention

➥ CompileStaticRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	34	[SRC]return new CompileStaticRule() [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

34

[SRC]return new CompileStaticRule()

[MSG]The return keyword is not needed and can be removed

Package: design

➥ NestedForLoopRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	106	[SRC]return inlineViolation('Nested for loop') [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

106

[SRC]return inlineViolation('Nested for loop')

[MSG]The return keyword is not needed and can be removed

➥ OptionalCollectionReturnTypeRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	128	[SRC]return "The method $methodName in class MyClass returns .. collection" [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

128

[SRC]return "The method $methodName in class MyClass returns .. collection"

[MSG]The return keyword is not needed and can be removed

➥ PrivateFieldCouldBeFinalRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	26	[SRC]class PrivateFieldCouldBeFinalRuleTest extends AbstractR..FinalRule> { [MSG]Class org.codenarc.rule.design.PrivateFieldCouldBeFinalRuleTest has 34 methods

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

26

[SRC]class PrivateFieldCouldBeFinalRuleTest extends AbstractR..FinalRule> {

[MSG]Class org.codenarc.rule.design.PrivateFieldCouldBeFinalRuleTest has 34 methods

Package: enhanced

➥ MissingOverrideAnnotationRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	261	[SRC]return "Method '$methodName' is overriding a method in '.. @Override." [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

261

[SRC]return "Method '$methodName' is overriding a method in '.. @Override."

[MSG]The return keyword is not needed and can be removed

Package: formatting

➥ BracesForForLoopRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	101	[SRC]final SOURCE = ''' [MSG]The String ' for(String name=${SomeClass.SOME_CONSTANT}; name==null;) // And what about {} { doStuff() } ' contains a GString-type expression: '${SomeClass.SOME_CONSTANT}; name==null;) // And what about {}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

101

[SRC]final SOURCE = '''

[MSG]The String ' for(String name=${SomeClass.SOME_CONSTANT}; name==null;) // And what about {} { doStuff() } ' contains a GString-type expression: '${SomeClass.SOME_CONSTANT}; name==null;) // And what about {}'

➥ BracesForIfElseRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	59	[SRC]final SOURCE = ''' [MSG]The String ' if (someContainer."${SomeClass.SOME_CONSTANT}" != null) // And what about {} { doStuff() } ' contains a GString-type expression: '${SomeClass.SOME_CONSTANT}" != null) // And what about {}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

59

[SRC]final SOURCE = '''

[MSG]The String ' if (someContainer."${SomeClass.SOME_CONSTANT}" != null) // And what about {} { doStuff() } ' contains a GString-type expression: '${SomeClass.SOME_CONSTANT}" != null) // And what about {}'

➥ BracesForMethodRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	28	[SRC]class BracesForMethodRuleTest extends AbstractRuleTestCa..ethodRule> { [MSG]Class org.codenarc.rule.formatting.BracesForMethodRuleTest has 38 methods
GStringExpressionWithinString	2	356	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { int size(String name = "${SomeClass.SOME_CONSTANT}") { return 99 } } ' contains a GString-type expression: '${SomeClass.SOME_CONSTANT}'

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

28

[SRC]class BracesForMethodRuleTest extends AbstractRuleTestCa..ethodRule> {

[MSG]Class org.codenarc.rule.formatting.BracesForMethodRuleTest has 38 methods

GStringExpressionWithinString

2

356

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { int size(String name = "${SomeClass.SOME_CONSTANT}") { return 99 } } ' contains a GString-type expression: '${SomeClass.SOME_CONSTANT}'

➥ BracesForTryCatchFinallyRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	181	[SRC]return rule [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

181

[SRC]return rule

[MSG]The return keyword is not needed and can be removed

➥ ClassEndsWithBlankLineRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	27	[SRC]class ClassEndsWithBlankLineRuleTest extends AbstractRul..kLineRule> { [MSG]Class org.codenarc.rule.formatting.ClassEndsWithBlankLineRuleTest has 33 methods

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

27

[SRC]class ClassEndsWithBlankLineRuleTest extends AbstractRul..kLineRule> {

[MSG]Class org.codenarc.rule.formatting.ClassEndsWithBlankLineRuleTest has 33 methods

➥ ClassStartsWithBlankLineRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	28	[SRC]class ClassStartsWithBlankLineRuleTest extends AbstractR..kLineRule> { [MSG]Class org.codenarc.rule.formatting.ClassStartsWithBlankLineRuleTest has 50 methods

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

28

[SRC]class ClassStartsWithBlankLineRuleTest extends AbstractR..kLineRule> {

[MSG]Class org.codenarc.rule.formatting.ClassStartsWithBlankLineRuleTest has 50 methods

➥ IndentationRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	26	[SRC]class IndentationRuleTest extends AbstractRuleTestCase<I..ationRule> { [MSG]Class org.codenarc.rule.formatting.IndentationRuleTest has 58 methods
GStringExpressionWithinString	2	609	[SRC]final SOURCE = ''' [MSG]The String ' \|class MyClass { \| private void execute() { \| try { \| executeWithArgs(args) \| } \| catch(Throwable t) { \| println "ERROR: ${t.message}" \| t.printStackTrace() // wrong column \| } \| finally { \| closeResources() \| } \| } \| private void executeOtherOne() { \| try { \| println 999 // wrong column \| executeWithArgs(args) \| } catch(Throwable t) { \| t.printStackTrace() \| } finally { \| closeResources() \| notifyUser() // wrong column \| } \| } \|} ' contains a GString-type expression: '${t.message}'
GStringExpressionWithinString	2	1018	[SRC]final SOURCE = ''' [MSG]The String ' \|project.files(project.configurations.scaconfig.files.findAll { File it -> it.name.endsWith '.aar' }.collect { File it -> \| MessageDigest sha1 = MessageDigest.getInstance('SHA1') \| String inputFile = 'COMMAND=PREPARE_LIBRARY\n' + \| "FILE_PATH=${it.absolutePath}\n" \| String hash = new BigInteger(1, sha1.digest(inputFile.bytes)).toString(16) \| cacheDir + hash + File.separator + 'output/jars/classes.jar' \|}).asFileTree ' contains a GString-type expression: '${it.absolutePath}'
GStringExpressionWithinString	2	1032	[SRC]final SOURCE = ''' [MSG]The String ' \|"${if (true) 'content' else ''}" ' contains a GString-type expression: '${if (true) 'content' else ''}'
GStringExpressionWithinString	2	1040	[SRC]final SOURCE = ''' [MSG]The String ' \|package com.sample \| \|trait RegressionTest { \| \| String callStackPath = "src/test/resources/callstacks/" \| \| /** \| * Checks the current callstack is the same as the reference callstack. \| * The reference callstack can be updated into a txt file in the callStackPath \| * \| * Pattern: <RegressionTest.callStackPath>/<ClassTestSimpleName><_subname>.txt \| * @param subname optional subname, used in the reference callstack filename \| */ \| void testNonRegression(String subname = '') { \| String targetFileName = "${callStackPath}${this.class.simpleName}" \| if (subname) { \| targetFileName += "_${subname}" \| } \| RegressionTestHelper.testNonRegression(helper, targetFileName) \| } \|} ' contains a GString-type expression: '${callStackPath}${this.class.simpleName}'
ClassSize	3	26	[MSG]Class "IndentationRuleTest" is 1191 lines

➥ IndentationRule_MethodChainingTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	82	[SRC]final SOURCE = ''' [MSG]The String ' \|buildFileList() \| .collect { File it -> \| MessageDigest sha1 = MessageDigest.getInstance('SHA1') \| String inputFile = 'COMMAND=PREPARE_LIBRARY\n' + \| "FILE_PATH=${it.absolutePath}\n" \| cacheDir + File.separator + inputFile + sha1 \| } \| .each { name -> \| println name \| } \|println "done" \| \|list2.collect { item -> \| item.name \|}.each { name -> println name } \| \|otherList.collect { item -> item.name }.each { name -> println name } \| \|if (expr instanceof ConstructorCallExpression \|\| expr instanceof CastExpression) { \| [Map, Iterable, List, Collection, ArrayList, Set, HashSet].findAll { \| AstUtil.classNodeImplementsType(expr.type, it) \| }.each { \| callbackFunction() \| } \|} ' contains a GString-type expression: '${it.absolutePath}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

82

[SRC]final SOURCE = '''

[MSG]The String ' |buildFileList() | .collect { File it -> | MessageDigest sha1 = MessageDigest.getInstance('SHA1') | String inputFile = 'COMMAND=PREPARE_LIBRARY\n' + | "FILE_PATH=${it.absolutePath}\n" | cacheDir + File.separator + inputFile + sha1 | } | .each { name -> | println name | } |println "done" | |list2.collect { item -> | item.name |}.each { name -> println name } | |otherList.collect { item -> item.name }.each { name -> println name } | |if (expr instanceof ConstructorCallExpression || expr instanceof CastExpression) { | [Map, Iterable, List, Collection, ArrayList, Set, HashSet].findAll { | AstUtil.classNodeImplementsType(expr.type, it) | }.each { | callbackFunction() | } |} ' contains a GString-type expression: '${it.absolutePath}'

➥ MissingBlankLineBeforeAnnotatedFieldRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	98	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { private @Autowired DataSource dataSource private @Value('${name}') String name } ' contains a GString-type expression: '${name}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

98

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { private @Autowired DataSource dataSource private @Value('${name}') String name } ' contains a GString-type expression: '${name}'

➥ SpaceAfterClosingBraceRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	38	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } // ok static void reset() { violationCounts = [1:0, 2:0, 3:0] } void doStuff() { println 9 } } interface MyInterface { } enum MyEnum { OK, BAD } ' contains a GString-type expression: '${priority}Violations") { }'
GStringExpressionWithinString	2	304	[SRC]assertNoViolations(''' [MSG]The String ' def foo = 1 "I am a ${ -> foo }" ' contains a GString-type expression: '${ -> foo }'
GStringExpressionWithinString	2	312	[SRC]assertNoViolations(''' [MSG]The String ' def foo = 1 "I am a ${ -> foo }0" ' contains a GString-type expression: '${ -> foo }'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

38

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } // ok static void reset() { violationCounts = [1:0, 2:0, 3:0] } void doStuff() { println 9 } } interface MyInterface { } enum MyEnum { OK, BAD } ' contains a GString-type expression: '${priority}Violations") { }'

GStringExpressionWithinString

2

304

[SRC]assertNoViolations('''

[MSG]The String ' def foo = 1 "I am a ${ -> foo }" ' contains a GString-type expression: '${ -> foo }'

GStringExpressionWithinString

2

312

[SRC]assertNoViolations('''

[MSG]The String ' def foo = 1 "I am a ${ -> foo }0" ' contains a GString-type expression: '${ -> foo }'

➥ SpaceAfterCommaRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	53	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def template() { return { td(getResourceBundleString('htmlReport.summary.allPackages'), class:'allPackages') td { a(pathName, href:"#${pathName}") } } } } ' contains a GString-type expression: '${pathName}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

53

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { def template() { return { td(getResourceBundleString('htmlReport.summary.allPackages'), class:'allPackages') td { a(pathName, href:"#${pathName}") } } } } ' contains a GString-type expression: '${pathName}'

➥ SpaceAfterOpeningBraceRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	40	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } MyClass(String s) { } MyClass(@Annotation('${prop}') String s) { } MyClass(Date date) { // comment this(classNames) } MyClass(Object object) { /* comment */ } } interface MyInterface { } enum MyEnum { OK, BAD } trait MyTrait { } ' contains a GString-type expression: '${priority}Violations") { }'
GStringExpressionWithinString	2	102	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def myMethod() { def closure = {} if (true) {} while(ready) {} try { } catch(Exception e) { } finally {} for(int i=0; i<10; i++) {} for(String name in names) {} for(String name: names) {} if (count > this."maxPriority${priority}Violations") {} while (count > this."maxPriority${priority}Violations") {} } void doStuff2() {} MyClass() {} MyClass(@Annotation('${prop}') String s) {} } interface MyInterface2 {} ' contains a GString-type expression: '${priority}Violations") {}'
GStringExpressionWithinString	2	196	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { MyClass() {int count } MyClass() {s = '{"json": true}' } MyClass(@Annotation('${prop}') String s) {println 123 } } ' contains a GString-type expression: '${prop}') String s) {println 123 }'
GStringExpressionWithinString	2	207	[SRC][line:5, source:'MyClass(@Annotation(\'${prop}\') String..s MyClass']) [MSG]The String 'MyClass(@Annotation('${prop}') String s) {println 123 }' contains a GString-type expression: '${prop}') String s) {println 123 }'
GStringExpressionWithinString	2	325	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { String s MyClass() { s = '{"json": true}' } MyClass(@Annotation('${prop}') String s) { println 123 } } ' contains a GString-type expression: '${prop}') String s) { println 123 }'

➥ SpaceAroundMapEntryColonRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	167	[SRC]return inlineViolation("The colon for the literal Map en..className" + [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

167

[SRC]return inlineViolation("The colon for the literal Map en..className" +

[MSG]The return keyword is not needed and can be removed

➥ SpaceBeforeClosingBraceRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	39	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } static void reset() { violationCounts = [1:0, 2:0, 3:0] } void doStuff() { println 9 } } interface MyInterface { } enum MyEnum { OK, BAD } ' contains a GString-type expression: '${priority}Violations") { }'
GStringExpressionWithinString	2	80	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def myMethod() { def closure = {} if (true) {} while(ready) {} try { } catch(Exception e) { } finally {} for(int i=0; i<10; i++) {} for(String name in names) {} for(String name: names) {} if (count > this."maxPriority${priority}Violations") {} while (count > this."maxPriority${priority}Violations") {} } void doStuff2() {} } interface MyInterface2 {} ' contains a GString-type expression: '${priority}Violations") {}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

39

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } static void reset() { violationCounts = [1:0, 2:0, 3:0] } void doStuff() { println 9 } } interface MyInterface { } enum MyEnum { OK, BAD } ' contains a GString-type expression: '${priority}Violations") { }'

GStringExpressionWithinString

2

80

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { def myMethod() { def closure = {} if (true) {} while(ready) {} try { } catch(Exception e) { } finally {} for(int i=0; i<10; i++) {} for(String name in names) {} for(String name: names) {} if (count > this."maxPriority${priority}Violations") {} while (count > this."maxPriority${priority}Violations") {} } void doStuff2() {} } interface MyInterface2 {} ' contains a GString-type expression: '${priority}Violations") {}'

➥ SpaceBeforeOpeningBraceRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	38	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } } interface MyInterface { } enum MyEnum { OK, BAD } trait MyTrait { } ' contains a GString-type expression: '${priority}Violations") { }'
GStringExpressionWithinString	2	277	[SRC]assertNoViolations(''' [MSG]The String ' def foo = 1 "I am a ${ -> foo }" ' contains a GString-type expression: '${ -> foo }'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

38

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { def myMethod() { def closure = { } if (true) { } while(ready) { } try { } catch(Exception e) { } finally { } for(int i=0; i<10; i++) { } for(String name in names) { } for(String name: names) { } if (count > this."maxPriority${priority}Violations") { } while (count > this."maxPriority${priority}Violations") { } } MyClass() { this(classNames) } } interface MyInterface { } enum MyEnum { OK, BAD } trait MyTrait { } ' contains a GString-type expression: '${priority}Violations") { }'

GStringExpressionWithinString

2

277

[SRC]assertNoViolations('''

[MSG]The String ' def foo = 1 "I am a ${ -> foo }" ' contains a GString-type expression: '${ -> foo }'

Package: generic

➥ IllegalPackageReferenceRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	64	[SRC]final SOURCE = ''' [MSG]The String ' if (value.class == org.bad.BadClass) { } println "isClosure=${value instanceof org.bad.OtherClass}" def count = org.bad.Helper.getCount() ' contains a GString-type expression: '${value instanceof org.bad.OtherClass}'
GStringExpressionWithinString	2	72	[SRC][line:3, source:'println "isClosure=${value instanceof o..:'org.bad'], [MSG]The String 'println "isClosure=${value instanceof org.bad.OtherClass}"' contains a GString-type expression: '${value instanceof org.bad.OtherClass}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

64

[SRC]final SOURCE = '''

[MSG]The String ' if (value.class == org.bad.BadClass) { } println "isClosure=${value instanceof org.bad.OtherClass}" def count = org.bad.Helper.getCount() ' contains a GString-type expression: '${value instanceof org.bad.OtherClass}'

GStringExpressionWithinString

2

72

[SRC][line:3, source:'println "isClosure=${value instanceof o..:'org.bad'],

[MSG]The String 'println "isClosure=${value instanceof org.bad.OtherClass}"' contains a GString-type expression: '${value instanceof org.bad.OtherClass}'

➥ StatelessClassRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	84	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { @Value('${org.codenarc.test}') BigDecimal depositAmount } ' contains a GString-type expression: '${org.codenarc.test}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

84

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { @Value('${org.codenarc.test}') BigDecimal depositAmount } ' contains a GString-type expression: '${org.codenarc.test}'

Package: grails

➥ GrailsMassAssignmentRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	36	[SRC]final SOURCE = ''' [MSG]The String ' class Person { String name Boolean isAdmin } def bindingMap = [name: 'John', isAdmin: true] def person = new Person() def p2 = new Person("It is currently ${ new Date() }") def p3 = new Person(bindingMap) person.name = bindingMap['name'] person.isAdmin = bindingMap.isAdmin person.properties = "It is currently ${ new Date() }" ' contains a GString-type expression: '${ new Date() }'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

36

[SRC]final SOURCE = '''

[MSG]The String ' class Person { String name Boolean isAdmin } def bindingMap = [name: 'John', isAdmin: true] def person = new Person() def p2 = new Person("It is currently ${ new Date() }") def p3 = new Person(bindingMap) person.name = bindingMap['name'] person.isAdmin = bindingMap.isAdmin person.properties = "It is currently ${ new Date() }" ' contains a GString-type expression: '${ new Date() }'

➥ GrailsServletContextReferenceRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	78	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def mySession = servletContext def edit = { println "amount=${servletContext.amount}" } } ' contains a GString-type expression: '${servletContext.amount}'
GStringExpressionWithinString	2	87	[SRC]assertTwoViolations(SOURCE, 3, 'def mySession = servletC..t.amount}"') [MSG]The String 'println "amount=${servletContext.amount}"' contains a GString-type expression: '${servletContext.amount}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

78

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { def mySession = servletContext def edit = { println "amount=${servletContext.amount}" } } ' contains a GString-type expression: '${servletContext.amount}'

GStringExpressionWithinString

2

87

[SRC]assertTwoViolations(SOURCE, 3, 'def mySession = servletC..t.amount}"')

[MSG]The String 'println "amount=${servletContext.amount}"' contains a GString-type expression: '${servletContext.amount}'

Package: groovyism

➥ ClosureAsLastMethodParameterRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	242	[SRC]final SOURCE = ''' [MSG]The String ' new Exception("${it.orElseThrow { new AssertionError() }}") ' contains a GString-type expression: '${it.orElseThrow { new AssertionError() }}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

242

[SRC]final SOURCE = '''

[MSG]The String ' new Exception("${it.orElseThrow { new AssertionError() }}") ' contains a GString-type expression: '${it.orElseThrow { new AssertionError() }}'

➥ GStringAsMapKeyRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	44	[SRC]final SOURCE = ''' [MSG]The String ' Map map = ["${ someRef }" : 'invalid' ] ' contains a GString-type expression: '${ someRef }'
GStringExpressionWithinString	2	48	[SRC]2, '["${ someRef }" :') [MSG]The String '["${ someRef }" :' contains a GString-type expression: '${ someRef }'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

44

[SRC]final SOURCE = '''

[MSG]The String ' Map map = ["${ someRef }" : 'invalid' ] ' contains a GString-type expression: '${ someRef }'

GStringExpressionWithinString

2

48

[SRC]2, '["${ someRef }" :')

[MSG]The String '["${ someRef }" :' contains a GString-type expression: '${ someRef }'

➥ GStringExpressionWithinStringRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	49	[SRC]final SOURCE = ''' [MSG]The String ' class SomeClass { @SomeAnnotationOnField('${sample.property1}') String sampleProperty @SomeAnnotationOnMethod('${sample.property2}') void method() { } } ' contains a GString-type expression: '${sample.property1}'
GStringExpressionWithinString	2	64	[SRC]final SOURCE = ''' [MSG]The String ' @SomeAnnotationOnClass('${sample.property1}') class SomeClass { @SomeAnnotationOnField('${sample.property2}') String sampleProperty @SomeAnnotationOnMethod('${sample.property3}') void method() { } } ' contains a GString-type expression: '${sample.property1}'
GStringExpressionWithinString	2	80	[SRC]final SOURCE = ''' [MSG]The String ' @SomeAnnotationOnClass(attribute='${sample.property1}', nested=[@NestedAnnotation('${sample.property2}'), @NestedAnnotation('${sample.property3}')], someOtherAttribute='${sample.property4}') class SomeClass { } ' contains a GString-type expression: '${sample.property1}'
GStringExpressionWithinString	2	93	[SRC]final SOURCE = ''' [MSG]The String ' @SomeAnnotationOnClass(attribute=['${sample.property1}', '${sample.property2}']) class SomeClass { } ' contains a GString-type expression: '${sample.property1}', '${sample.property2}'
GStringExpressionWithinString	2	103	[SRC]final SOURCE = ''' [MSG]The String ' def valueToBeReplaced = '123' def str1 = "123" def str2 = "abc def ghi" def str3 = "abc ${count}" def str4 = "abc $count }" def str5 = "abc {123}" def str6 = "abc ${}" def str7 = "total: ${count * 25}" def str8 = "$valueToBeReplaced $valueNotToBeReplaced" ' contains a GString-type expression: '${count}'
GStringExpressionWithinString	2	119	[SRC]final SOURCE = ''' [MSG]The String ' def "plugin does not apply idea plugin"() { given: buildScript << """ task $testTaskName { doLast { println "Has idea plugin: \${project.plugins.hasPlugin(IdeaPlugin)}" } } """ expect: runTask(testTaskName).output.contains('Has idea plugin: false') where: testTaskName = 'hasIdeaPlugin' } ' contains a GString-type expression: '${project.plugins.hasPlugin(IdeaPlugin)}'
GStringExpressionWithinString	2	142	[SRC]final SOURCE = ''' [MSG]The String ' def str1 = 'total: ${count}' def str2 = 'average: ${total / count}' ' contains a GString-type expression: '${count}'
GStringExpressionWithinString	2	147	[SRC][line:2, source:"def str1 = 'total: \${count}'", message..{count}\''], [MSG]The String 'def str1 = 'total: ${count}'' contains a GString-type expression: '${count}'
GStringExpressionWithinString	2	147	[SRC][line:2, source:"def str1 = 'total: \${count}'", message..{count}\''], [MSG]The String ''${count}'' contains a GString-type expression: '${count}'
GStringExpressionWithinString	2	148	[SRC][line:3, source:"def str2 = 'average: \${total / count}'.. count}\'']) [MSG]The String 'def str2 = 'average: ${total / count}'' contains a GString-type expression: '${total / count}'
GStringExpressionWithinString	2	148	[SRC][line:3, source:"def str2 = 'average: \${total / count}'.. count}\'']) [MSG]The String ''${total / count}'' contains a GString-type expression: '${total / count}'
GStringExpressionWithinString	2	153	[SRC]final SOURCE = ''' [MSG]The String ' class SomeClass { @SomeAnnotationOnMethod('${sample.property}') void method() { def str1 = 'total: ${count}' } } ' contains a GString-type expression: '${sample.property}'
GStringExpressionWithinString	2	161	[SRC]assertSingleViolation(SOURCE, 5, "def str1 = 'total: \${..${count}\'') [MSG]The String 'def str1 = 'total: ${count}'' contains a GString-type expression: '${count}'
GStringExpressionWithinString	2	161	[SRC]assertSingleViolation(SOURCE, 5, "def str1 = 'total: \${..${count}\'') [MSG]The String ''${count}'' contains a GString-type expression: '${count}'
GStringExpressionWithinString	2	166	[SRC]final SOURCE = ''' [MSG]The String ' class SomeClass { @SomeAnnotationOnField(someClass = SomeOtherClass, message = 'Some message ${sample.property1}') String sampleProperty } ' contains a GString-type expression: '${sample.property1}'

Package: imports

➥ UnusedImportRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	215	[SRC]final SOURCE = ''' [MSG]The String ' import test.TestData1 import test.TestData2 import test.TestData3 import test.TestData4 import test.TestData5 import test.TestData6 import test.TestData7 import test.TestData8 import test.TestData9 import test.TestData10 import test.TestData11 import test.TestData12 import test.TestData13 import test.TestData14 import test.TestData15 def GSTRING1 = " ${TestData1.GOOD_XML}" def GSTRING2 = " $TestData2.XML" def MAP1 = [(TestData3):123] def MAP2 = [abc:TestData4] def MAP3 = [abc:TestData5, ddd:123] def LIST = [TestData6,TestData7] def OPERATORS1 = 0+TestData8.VALUE-TestData9.VALUE def OPERATORS2 = 9*TestData10.VALUE/TestData11.VALUE def OPERATORS3 = 64&TestData12.VALUE\|TestData13.VALUE^TestData14.VALUE def OPERATORS4 = !TestData15.VALUE ' contains a GString-type expression: '${TestData1.GOOD_XML}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

215

[SRC]final SOURCE = '''

[MSG]The String ' import test.TestData1 import test.TestData2 import test.TestData3 import test.TestData4 import test.TestData5 import test.TestData6 import test.TestData7 import test.TestData8 import test.TestData9 import test.TestData10 import test.TestData11 import test.TestData12 import test.TestData13 import test.TestData14 import test.TestData15 def GSTRING1 = " ${TestData1.GOOD_XML}" def GSTRING2 = " $TestData2.XML" def MAP1 = [(TestData3):123] def MAP2 = [abc:TestData4] def MAP3 = [abc:TestData5, ddd:123] def LIST = [TestData6,TestData7] def OPERATORS1 = 0+TestData8.VALUE-TestData9.VALUE def OPERATORS2 = 9*TestData10.VALUE/TestData11.VALUE def OPERATORS3 = 64&TestData12.VALUE|TestData13.VALUE^TestData14.VALUE def OPERATORS4 = !TestData15.VALUE ' contains a GString-type expression: '${TestData1.GOOD_XML}'

Package: naming

➥ FieldNameRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	28	[SRC]class FieldNameRuleTest extends AbstractRuleTestCase<FieldNameRule> { [MSG]Class org.codenarc.rule.naming.FieldNameRuleTest has 32 methods

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

28

[SRC]class FieldNameRuleTest extends AbstractRuleTestCase<FieldNameRule> {

[MSG]Class org.codenarc.rule.naming.FieldNameRuleTest has 32 methods

Package: size

➥ GMetricsSourceCodeAdapterTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MisorderedStaticImports	3	22	[SRC]import static org.codenarc.test.TestUtil.shouldFailWithM..geContaining [MSG]Static imports should appear before normal imports

Rule Name

Priority

Line #

Source Line / Message

MisorderedStaticImports

3

22

[SRC]import static org.codenarc.test.TestUtil.shouldFailWithM..geContaining

[MSG]Static imports should appear before normal imports

➥ ParameterCountRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
UnnecessaryReturnKeyword	3	252	[SRC]return inlineViolation("Number of parameters in ${name} ..ameters}).") [MSG]The return keyword is not needed and can be removed

Rule Name

Priority

Line #

Source Line / Message

UnnecessaryReturnKeyword

3

252

[SRC]return inlineViolation("Number of parameters in ${name} ..ameters}).")

[MSG]The return keyword is not needed and can be removed

Package: unnecessary

➥ ConsecutiveStringConcatenationRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	65	[SRC]final SOURCE = ''' [MSG]The String ' def b = "$Hello" + 'World' // should be "${Hello}World" ' contains a GString-type expression: '${Hello}'
GStringExpressionWithinString	2	73	[SRC]final SOURCE = ''' [MSG]The String ' def c = 'Hello' + "$World" // should be "Hello${World}" ' contains a GString-type expression: '${World}'

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

65

[SRC]final SOURCE = '''

[MSG]The String ' def b = "$Hello" + 'World' // should be "${Hello}World" ' contains a GString-type expression: '${Hello}'

GStringExpressionWithinString

2

73

[SRC]final SOURCE = '''

[MSG]The String ' def c = 'Hello' + "$World" // should be "Hello${World}" ' contains a GString-type expression: '${World}'

➥ UnnecessaryGStringRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

36

[SRC]final SOURCE = '''

[MSG]The String ' def docFile = "docs/codenarc-rules-${ruleSetName}.apt" ' contains a GString-type expression: '${ruleSetName}'

➥ UnnecessaryGetterRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

180

[SRC]final SOURCE = '''

[MSG]The String ' Mock { getSomeData() } Stub(1,2,3) { getData2() } "${'Stub'}"(MyClass) { getData3() } def closure = { getData4() } Mock({ getData5() }, 1234) // 2nd param is not a Closure Spy { getMoreData() } ' contains a GString-type expression: '${'Stub'}'

➥ UnnecessaryPackageReferenceRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

66

[SRC]final SOURCE = '''

[MSG]The String ' if (value.class == java.math.BigDecimal) { } println "isClosure=${value instanceof groovy.lang.Closure}" def processors = java.lang.Runtime.availableProcessors() ' contains a GString-type expression: '${value instanceof groovy.lang.Closure}'

GStringExpressionWithinString

2

73

[SRC][line:3, source:'println "isClosure=${value instanceof g..oovy.lang'],

[MSG]The String 'println "isClosure=${value instanceof groovy.lang.Closure}"' contains a GString-type expression: '${value instanceof groovy.lang.Closure}'

➥ UnnecessarySetterRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

97

[SRC]final SOURCE = '''

[MSG]The String ' if (!file.setExecutable(true)) { throw new Exception("Cannot set ${file} as executable") } def count = x.setCount(92) ' contains a GString-type expression: '${file}'

➥ UnnecessaryToStringRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
GStringExpressionWithinString	2	67	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { def name = "Joe" + new Date().toString() void run() { Object object = 1 def string = 'some string' + object.toString() def withinGString = "processing: ${'prefix' + object.toString()}" def bigString = 'some string' + new Date() + object.toString() // not a violation; known limitation def other = 123 + object.toString().toInteger() // not a violation } } ' contains a GString-type expression: '${'prefix' + object.toString()}'
GStringExpressionWithinString	2	84	[SRC][line:8, source:'def withinGString = "processing: ${\'pr..necessary']) [MSG]The String 'def withinGString = "processing: ${'prefix' + object.toString()}"' contains a GString-type expression: '${'prefix' + object.toString()}'
GStringExpressionWithinString	2	89	[SRC]final SOURCE = ''' [MSG]The String ' def string = "some string${123L.toString()} or ${123} or ${'ABC'} or ${new Date().toString()}" def string2 = """ processing: ${123L.toString()} processing: ${new Date().toString()} """ ' contains a GString-type expression: '${123L.toString()} or ${123} or ${'ABC'} or ${new Date().toString()}'
GStringExpressionWithinString	2	97	[SRC][line:2, source:'def string = "some string${123L.toStrin..necessary'], [MSG]The String 'def string = "some string${123L.toString()} or ${123} or ${'ABC'} or ${new Date().toString()}"' contains a GString-type expression: '${123L.toString()} or ${123} or ${'ABC'} or ${new Date().toString()}'
GStringExpressionWithinString	2	98	[SRC][line:2, source:'def string = "some string${123L.toStrin..necessary'], [MSG]The String 'def string = "some string${123L.toString()} or ${123} or ${'ABC'} or ${new Date().toString()}"' contains a GString-type expression: '${123L.toString()} or ${123} or ${'ABC'} or ${new Date().toString()}'
GStringExpressionWithinString	2	99	[SRC][line:4, source:'processing: ${123L.toString()}', messag..necessary'], [MSG]The String 'processing: ${123L.toString()}' contains a GString-type expression: '${123L.toString()}'
GStringExpressionWithinString	2	100	[SRC][line:5, source:'processing: ${new Date().toString()}', ..nnecessary'] [MSG]The String 'processing: ${new Date().toString()}' contains a GString-type expression: '${new Date().toString()}'

Package: unused

➥ AbstractUnusedPrivateFieldRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

27

[SRC]abstract class AbstractUnusedPrivateFieldRuleTest extend..FieldRule> {

[MSG]Class org.codenarc.rule.unused.AbstractUnusedPrivateFieldRuleTest has 32 methods

GStringExpressionWithinString

2

172

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { private int count def other = this."${'count'}" } ' contains a GString-type expression: '${'count'}'

GStringExpressionWithinString

2

183

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { private int count def varName = "count" def other = this."${varName}" // can't see this } ' contains a GString-type expression: '${varName}'

➥ UnusedMethodParameterRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

150

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { MyClass() { } MyClass(String id) { println id } String myMethod1(String id, int value) { doSomething(value); return id } void myMethod2(int value) { def x = value } def myMethod3(Date startDate) { return "${startDate}" } def myMethod4(Date startDate) { return new Object() { def x = startDate } } def myMethod5(Date startDate) { return new Object() { String toString() { return startDate } } } } ' contains a GString-type expression: '${startDate}" }'

➥ UnusedPrivateMethodParameterRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

GStringExpressionWithinString

2

126

[SRC]final SOURCE = '''

[MSG]The String ' class MyClass { private String myMethod1(String id, int value) { doSomething(value); return id } private void myMethod2(int value) { def x = value } private def myMethod3(Date startDate) { return "${startDate}" } private def myMethod4(Date startDate) { return new Object() { def x = startDate } } private def myMethod5(Date startDate) { return new Object() { String toString() { return startDate } } } } ' contains a GString-type expression: '${startDate}" }'

➥ UnusedPrivateMethodRuleTest.groovy

Rule Name	Priority	Line #	Source Line / Message
MethodCount	2	26	[SRC]class UnusedPrivateMethodRuleTest extends AbstractRuleTe..ethodRule> { [MSG]Class org.codenarc.rule.unused.UnusedPrivateMethodRuleTest has 37 methods
GStringExpressionWithinString	2	354	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { private int countStuff() { return 99 } int somePublicMethod() { } def abc = 'abc' private String getName() { 'abc' } private getPrice() { 0.0 } def doStuff() { def count = countStuff() def newName = this.getName() } def myClosure = { println "price is ${getPrice()}" } } ' contains a GString-type expression: '${getPrice()}" }'
GStringExpressionWithinString	2	423	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { static int getTotal() { println "total=${MyClass.countStuff()}" } private static int countStuff() { } } ' contains a GString-type expression: '${MyClass.countStuff()}'
GStringExpressionWithinString	2	436	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { private int countStuff() { } def other = this."${countStuff}"() } ' contains a GString-type expression: '${countStuff}'
GStringExpressionWithinString	2	458	[SRC]final SOURCE = ''' [MSG]The String ' class MyClass { private int countStuff() { } def varName = "countStuff" def other = this."${varName}"() // can't see this } ' contains a GString-type expression: '${varName}'

➥ UnusedVariableRuleTest.groovy

Rule Name

Priority

Line #

Source Line / Message

MethodCount

2

26

[SRC]class UnusedVariableRuleTest extends AbstractRuleTestCas..iableRule> {

[MSG]Class org.codenarc.rule.unused.UnusedVariableRuleTest has 35 methods

Rule Descriptions

#	Rule Name	Description
1	AbcMetric	Checks the ABC size metric for methods/classes. A method (or "closure field") with an ABC score greater than the maxMethodAbcScore property (60) causes a violation. Likewise, a class that has an (average method) ABC score greater than the maxClassAverageMethodAbcScore property (60) causes a violation.
2	AddEmptyString	Finds empty string literals which are being added. This is an inefficient way to convert any type to a String.
3	AssertWithinFinallyBlock	Checks for assert statements within a finally block. An assert can throw an exception, hiding the original exception, if there is one.
4	AssignCollectionSort	The Collections.sort() method mutates the list and returns the list as a value. If you are assigning the result of sort() to a variable, then you probably don't realize that you're also modifying the original list as well. This is frequently the cause of subtle bugs.
5	AssignCollectionUnique	The Collections.unique() method mutates the list and returns the list as a value. If you are assigning the result of unique() to a variable, then you probably don't realize that you're also modifying the original list as well. This is frequently the cause of subtle bugs.
6	AssignmentInConditional	An assignment operator (=) was used in a conditional test. This is usually a typo, and the comparison operator (==) was intended.
7	BigDecimalInstantiation	Checks for calls to the BigDecimal constructors that take a double parameter, which may result in an unexpected BigDecimal value.
8	BitwiseOperatorInConditional	Checks for bitwise operations in conditionals, if you need to do a bitwise operation then it is best practice to extract a temp variable.
9	BooleanGetBoolean	This rule catches usages of java.lang.Boolean.getBoolean(String) which reads a boolean from the System properties. It is often mistakenly used to attempt to read user input or parse a String into a boolean. It is a poor piece of API to use; replace it with System.properties['prop'].
10	BrokenNullCheck	Looks for faulty checks for null that can cause a NullPointerException.
11	BrokenOddnessCheck	The code uses x % 2 == 1 to check to see if a value is odd, but this won't work for negative numbers (e.g., (-5) % 2 == -1). If this code is intending to check for oddness, consider using x & 1 == 1, or x % 2 != 0.
12	ClassForName	Using Class.forName(...) is a common way to add dynamic behavior to a system. However, using this method can cause resource leaks because the classes can be pinned in memory for long periods of time.
13	ClassSize	Checks if the size of a class exceeds the number of lines specified by the maxLines property (1000).
14	ClosureAsLastMethodParameter	If a method is called and the last parameter is an inline closure then it can be declared outside of the method call brackets.
15	CollectAllIsDeprecated	collectAll{} is deprecated since Groovy 1.8.1. Use collectNested instead{}.
16	ComparisonOfTwoConstants	Checks for expressions where a comparison operator or equals() or compareTo() is used to compare two constants to each other or two literals that contain only constant values., e.g.: 23 == 67, Boolean.FALSE != false, 0.17 <= 0.99, "abc" > "ddd", [a:1] <=> [a:2], [1,2].equals([3,4]) or [a:false, b:true].compareTo(['a':34.5, b:Boolean.TRUE].
17	ComparisonWithSelf	Checks for expressions where a comparison operator or equals() or compareTo() is used to compare a variable to itself, e.g.: x == x, x != x, x <=> x, x < x, x =>= x, x.equals(x) or x.compareTo(x), where x is a variable.
18	ConfusingMultipleReturns	Multiple return values can be used to set several variables at once. To use multiple return values, the left hand side of the assignment must be enclosed in parenthesis. If not, then you are not using multiple return values, you're only assigning the last element.
19	ConsecutiveLiteralAppends	Violations occur when method calls to append(Object) are chained together with literals as parameters. The chained calls can be joined into one invocation.
20	ConsecutiveStringConcatenation	Catches concatenation of two string literals on the same line. These can safely by joined.
21	ConstantAssertExpression	Checks for assert statements where the assert boolean condition expression is a constant or literal value.
22	ConstantIfExpression	Checks for if statements with a constant value for the if expression, such as true, false, null, or a literal constant value.
23	ConstantTernaryExpression	Checks for ternary expressions with a constant value for the boolean expression, such as true, false, null, or a literal constant value.
24	CrapMetric	Checks the CRAP (Change Risk Anti-Patterns) score for methods/classes. The CRAP metric score is based on the cyclomatic complexity and test coverage for individual methods. A method with a CRAP value greater than the maxMethodCrapScore property (30) causes a violation. Likewise, a class that has an (average method) CRAP value greater than the maxClassAverageMethodCrapScore property (30) causes a violation.
25	CyclomaticComplexity	Checks the cyclomatic complexity for methods/classes.A method (or "closure field") with a cyclomatic complexity value greater than the maxMethodComplexity property (20) causes a violation. Likewise, a class that has an (average method) cyclomatic complexityvalue greater than the maxClassAverageMethodComplexity property (20) causes a violation.
26	DeadCode	Dead code appears after a return statement or an exception is thrown. If code appears after one of these statements then it will never be executed and can be safely deleted.
27	DoubleNegative	There is no point in using a double negative, it is always positive. For instance !!x can always be simplified to x. And !(!x) can as well.
28	DuplicateCaseStatement	Check for duplicate case statements in a switch block, such as two equal integers or strings.
29	DuplicateImport	Duplicate import statements are unnecessary.
30	DuplicateMapKey	A map literal is created with duplicated key. The map entry will be overwritten.
31	DuplicateSetValue	A Set literal is created with duplicate constant value. A set cannot contain two elements with the same value.
32	EmptyCatchBlock	In most cases, exceptions should not be caught and ignored (swallowed).
33	EmptyClass	Reports classes without methods, fields or properties. Why would you need a class like this?
34	EmptyElseBlock	Empty else blocks are confusing and serve no purpose.
35	EmptyFinallyBlock	Empty finally blocks are confusing and serve no purpose.
36	EmptyForStatement	Empty for statements are confusing and serve no purpose.
37	EmptyIfStatement	Empty if statements are confusing and serve no purpose.
38	EmptyInstanceInitializer	An empty class instance initializer was found. It is safe to remove it.
39	EmptyMethod	A method was found without an implementation. If the method is overriding or implementing a parent method, then mark it with the @Override annotation.
40	EmptyStaticInitializer	An empty static initializer was found. It is safe to remove it.
41	EmptySwitchStatement	Empty switch statements are confusing and serve no purpose.
42	EmptySynchronizedStatement	Empty synchronized statements are confusing and serve no purpose.
43	EmptyTryBlock	Empty try blocks are confusing and serve no purpose.
44	EmptyWhileStatement	Empty while statements are confusing and serve no purpose.
45	EqualsAndHashCode	If either the boolean equals(Object) or the int hashCode() methods are overridden within a class, then both must be overridden.
46	EqualsOverloaded	The class has an equals method, but the parameter of the method is not of type Object. It is not overriding equals but instead overloading it.
47	ExplicitArrayListInstantiation	This rule checks for the explicit instantiation of an ArrayList using the no-arg constructor. In Groovy, it is best to write new ArrayList() as [], which creates the same object.
48	ExplicitCallToAndMethod	This rule detects when the and(Object) method is called directly in code instead of using the & operator. A groovier way to express this: a.and(b) is this: a & b
49	ExplicitCallToCompareToMethod	This rule detects when the compareTo(Object) method is called directly in code instead of using the <=>, >, >=, <, and <= operators. A groovier way to express this: a.compareTo(b) is this: a <=> b, or using the other operators.
50	ExplicitCallToDivMethod	This rule detects when the div(Object) method is called directly in code instead of using the / operator. A groovier way to express this: a.div(b) is this: a / b
51	ExplicitCallToEqualsMethod	This rule detects when the equals(Object) method is called directly in code instead of using the == or != operator. A groovier way to express this: a.equals(b) is this: a == b and a groovier way to express : !a.equals(b) is : a != b
52	ExplicitCallToGetAtMethod	This rule detects when the getAt(Object) method is called directly in code instead of using the [] index operator. A groovier way to express this: a.getAt(b) is this: a[b]
53	ExplicitCallToLeftShiftMethod	This rule detects when the leftShift(Object) method is called directly in code instead of using the << operator. A groovier way to express this: a.leftShift(b) is this: a << b
54	ExplicitCallToMinusMethod	This rule detects when the minus(Object) method is called directly in code instead of using the - operator. A groovier way to express this: a.minus(b) is this: a - b
55	ExplicitCallToModMethod	This rule detects when the mod(Object) method is called directly in code instead of using the % operator. A groovier way to express this: a.mod(b) is this: a % b
56	ExplicitCallToMultiplyMethod	This rule detects when the minus(Object) method is called directly in code instead of using the * operator. A groovier way to express this: a.multiply(b) is this: a b*
57	ExplicitCallToOrMethod	This rule detects when the or(Object) method is called directly in code instead of using the \| operator. A groovier way to express this: a.or(b) is this: a \| b
58	ExplicitCallToPlusMethod	This rule detects when the plus(Object) method is called directly in code instead of using the + operator. A groovier way to express this: a.plus(b) is this: a + b
59	ExplicitCallToPowerMethod	This rule detects when the power(Object) method is called directly in code instead of using the ** operator. A groovier way to express this: a.power(b) is this: a * b*
60	ExplicitCallToPutAtMethod	Detects when the putAt(Object, Object) method is called directly in code instead of using the [] index operator. A groovier way to express this: map.putAt(k, v) is this: map[k] = v.
61	ExplicitCallToRightShiftMethod	This rule detects when the rightShift(Object) method is called directly in code instead of using the >> operator. A groovier way to express this: a.rightShift(b) is this: a >> b
62	ExplicitCallToXorMethod	This rule detects when the xor(Object) method is called directly in code instead of using the ^ operator. A groovier way to express this: a.xor(b) is this: a ^ b
63	ExplicitGarbageCollection	Calls to System.gc(), Runtime.getRuntime().gc(), and System.runFinalization() are not advised. Code should have the same behavior whether the garbage collection is disabled using the option -Xdisableexplicitgc or not. Moreover, "modern" jvms do a very good job handling garbage collections. If memory usage issues unrelated to memory leaks develop within an application, it should be dealt with JVM options rather than within the code itself.
64	ExplicitHashMapInstantiation	This rule checks for the explicit instantiation of a HashMap using the no-arg constructor. In Groovy, it is best to write new HashMap() as [:], which creates the same object.
65	ExplicitHashSetInstantiation	This rule checks for the explicit instantiation of a HashSet using the no-arg constructor. In Groovy, it is best to write new HashSet() as [] as Set, which creates the same object.
66	ExplicitLinkedHashMapInstantiation	This rule checks for the explicit instantiation of a LinkedHashMap using the no-arg constructor. In Groovy, it is best to write new LinkedHashMap() as [:], which creates the same object.
67	ExplicitLinkedListInstantiation	This rule checks for the explicit instantiation of a LinkedList using the no-arg constructor. In Groovy, it is best to write new LinkedList() as [] as Queue, which creates the same object.
68	ExplicitStackInstantiation	This rule checks for the explicit instantiation of a Stack using the no-arg constructor. In Groovy, it is best to write new Stack() as [] as Stack, which creates the same object.
69	ExplicitTreeSetInstantiation	This rule checks for the explicit instantiation of a TreeSet using the no-arg constructor. In Groovy, it is best to write new TreeSet() as [] as SortedSet, which creates the same object.
70	ForLoopShouldBeWhileLoop	A for loop without an init and update statement can be simplified to a while loop.
71	GStringAsMapKey	A GString should not be used as a map key since its hashcode is not guaranteed to be stable. Consider calling key.toString().
72	GStringExpressionWithinString	Check for regular (single quote) strings containing a GString-type expression (${...}).
73	GetterMethodCouldBeProperty	If a class defines a public method that follows the Java getter notation, and returns a constant, then it is cleaner to provide a Groovy property for the value rather than a Groovy method.
74	GroovyLangImmutable	The groovy.lang.Immutable annotation has been deprecated and replaced by groovy.transform.Immutable. Do not use the Immutable in groovy.lang.
75	HardCodedWindowsFileSeparator	This rule finds usages of a Windows file separator within the constructor call of a File object. It is better to use the Unix file separator or use the File.separator constant.
76	HardCodedWindowsRootDirectory	This rule find cases where a File object is constructed with a windows-based path. This is not portable, and using the File.listRoots() method is a better alternative.
77	ImportFromSamePackage	An import of a class that is within the same package is unnecessary.
78	ImportFromSunPackages	Avoid importing anything from the 'sun.*' packages. These packages are not portable and are likely to change.
79	IntegerGetInteger	This rule catches usages of java.lang.Integer.getInteger(String, ...) which reads an Integer from the System properties. It is often mistakenly used to attempt to read user input or parse a String into an Integer. It is a poor piece of API to use; replace it with System.properties['prop'].
80	MethodCount	A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.The maxMethods property (30) specifies the threshold.
81	MethodSize	Checks if the size of a method exceeds the number of lines specified by the maxLines property (100).
82	MisorderedStaticImports	Static imports should never be declared after nonstatic imports.
83	MultipleUnaryOperators	Checks for multiple consecutive unary operators. These are confusing, and are likely typos and bugs.
84	NestedBlockDepth	Checks for blocks or closures nested more than maxNestedBlockDepth (5) levels deep.
85	NoWildcardImports	Wildcard imports, static or otherwise, should not be used.
86	ParameterAssignmentInFilterClosure	An assignment operator was used on a parameter in a filtering closure. This is usually a typo, and the comparison operator (==) was intended.
87	ParameterCount	Checks if the number of parameters in method/constructor exceeds the number of parameters specified by the maxParameters property.
88	RandomDoubleCoercedToZero	The Math.random() method returns a double result greater than or equal to 0.0 and less than 1.0. If you coerce this result into an Integer or int, then it is coerced to zero. Casting the result to int, or assigning it to an int field is probably a bug.
89	RemoveAllOnSelf	Don't use removeAll to clear a collection. If you want to remove all elements from a collection c, use c.clear, not c.removeAll(c). Calling c.removeAll(c) to clear a collection is less clear, susceptible to errors from typos, less efficient and for some collections, might throw a ConcurrentModificationException.
90	ReturnFromFinallyBlock	Returning from a finally block is confusing and can hide the original exception.
91	ThrowExceptionFromFinallyBlock	Throwing an exception from a finally block is confusing and can hide the original exception.
92	UnnecessaryBigDecimalInstantiation	It is unnecessary to instantiate BigDecimal objects. Instead just use the decimal literal or the 'G' identifier to force the type, such as 123.45 or 123.45G.
93	UnnecessaryBigIntegerInstantiation	It is unnecessary to instantiate BigInteger objects. Instead just use the literal with the 'G' identifier to force the type, such as 8G or 42G.
94	UnnecessaryBooleanExpression	Checks for unnecessary boolean expressions, including ANDing (&&) or ORing (\|\|) with true, false, null, or a Map/List/String/Number literal. Also checks for negation (!) of true, false, null, or a Map/List/String/Number literal.
95	UnnecessaryBooleanInstantiation	Use Boolean.valueOf() for variable values or Boolean.TRUE and Boolean.FALSE for constant values instead of calling the Boolean() constructor directly or calling Boolean.valueOf(true) or Boolean.valueOf(false).
96	UnnecessaryCallForLastElement	This rule checks for excessively verbose methods of accessing the last element of an array or list. For instance, it is possible to access the last element of an array by performing array[array.length - 1], in Groovy it is simpler to either call array.last() or array[-1]. The same is true for lists. This violation is triggered whenever a get, getAt, or array-style access is used with an object size check.
97	UnnecessaryCallToSubstring	Calling String.substring(0) always returns the original string. This code is meaningless.
98	UnnecessaryCast	Checks for unnecessary cast operations
99	UnnecessaryCatchBlock	Violations are triggered when a catch block does nothing but throw the original exception. In this scenario there is usually no need for a catch block, just let the exception be thrown from the original code. This condition frequently occurs when catching an exception for debugging purposes but then forgetting to take the catch statement out.
100	UnnecessaryCollectCall	Some method calls to Object.collect(Closure) can be replaced with the spread operator. For instance, list.collect { it.multiply(2) } can be replaced by list.multiply(2). Warning: if a collection is null, collect will return an empty list, while . will return null.
101	UnnecessaryCollectionCall	Useless call to collections. This call doesn't make sense. For any collection c, calling c.containsAll(c) should always be true, and c.retainAll(c) should have no effect.
102	UnnecessaryConstructor	This rule detects when a constructor is not necessary; i.e., when there's only one constructor, it's public, has an empty body, and takes no arguments.
103	UnnecessaryDefInFieldDeclaration	If a field has a visibility modifier or a type declaration, then the def keyword is unneeded. For instance, 'static def constraints = {}' is redundant and can be simplified to 'static constraints = {}.
104	UnnecessaryDefInMethodDeclaration	If a method has a visibility modifier or a type declaration, then the def keyword is unneeded. For instance 'def private method() {}' is redundant and can be simplified to 'private method() {}'.
105	UnnecessaryDefInVariableDeclaration	If a variable has a visibility modifier or a type declaration, then the def keyword is unneeded. For instance 'def private n = 2' is redundant and can be simplified to 'private n = 2'.
106	UnnecessaryDotClass	To make a reference to a class, it is unnecessary to specify the '.class' identifier. For instance String.class can be shortened to String.
107	UnnecessaryDoubleInstantiation	It is unnecessary to instantiate Double objects. Instead just use the double literal or the 'D' identifier to force the type, such as 123.45d or 0.42d.
108	UnnecessaryElseStatement	When an if statement block ends with a return statement the else is unnecessary. The logic in the else branch can be run without being in a new scope.
109	UnnecessaryFinalOnPrivateMethod	A private method is marked final. Private methods cannot be overridden, so marking it final is unnecessary.
110	UnnecessaryFloatInstantiation	It is unnecessary to instantiate Float objects. Instead just use the float literal with the 'F' identifier to force the type, such as 123.45F or 0.42f.
111	UnnecessaryGString	String objects should be created with single quotes, and GString objects created with double quotes. Creating normal String objects with double quotes is confusing to readers.
112	UnnecessaryGroovyImport	A Groovy file does not need to include an import for classes from java.lang, java.util, java.io, java.net, groovy.lang and groovy.util, as well as the classes java.math.BigDecimal and java.math.BigInteger.
113	UnnecessaryIfStatement	Checks for if statements where the if and else blocks (or subsequent fall-through to a return) are merely returning true and false constants. These cases can be replaced by a simple return statement.
114	UnnecessaryInstanceOfCheck	This rule finds instanceof checks that cannot possibly evaluate to true. For instance, checking that (!variable instanceof String) will never be true because the result of a not expression is always a boolean.
115	UnnecessaryInstantiationToGetClass	Avoid instantiating an object just to call getClass() on it; use the .class public member instead.
116	UnnecessaryIntegerInstantiation	It is unnecessary to instantiate Integer objects. Instead just use the literal with the 'I' identifier to force the type, such as 8I or 42i.
117	UnnecessaryLongInstantiation	It is unnecessary to instantiate Long objects. Instead just use the literal with the 'L' identifier to force the type, such as 8L or 42L.
118	UnnecessaryModOne	Any expression mod 1 (exp % 1) is guaranteed to always return zero. This code is probably an error, and should be either (exp & 1) or (exp % 2).
119	UnnecessaryNullCheck	Groovy contains the safe dereference operator, which can be used in boolean conditional statements to safely replace explicit "x == null" tests.
120	UnnecessaryNullCheckBeforeInstanceOf	There is no need to check for null before an instanceof; the instanceof keyword returns false when given a null argument.
121	UnnecessaryObjectReferences	Violations are triggered when an excessive set of consecutive statements all reference the same variable. This can be made more readable by using a with or identity block.
122	UnnecessaryOverridingMethod	The overriding method merely calls the same method defined in a superclass
123	UnnecessaryPackageReference	Checks for explicit package reference for classes that Groovy imports by default, such as java.lang.String, java.util.Map and groovy.lang.Closure.
124	UnnecessaryParenthesesForMethodCallWithClosure	If a method is called and the only parameter to that method is an inline closure then the parentheses of the method call can be omitted.
125	UnnecessaryPublicModifier	The 'public' modifier is not required on methods or classes.
126	UnnecessaryReturnKeyword	In Groovy, the return keyword is often optional. If a statement is the last line in a method or closure then you do not need to have the return keyword.
127	UnnecessarySafeNavigationOperator	Check for the safe navigation operator (?.) applied to constants and literals, which can never be null.
128	UnnecessarySelfAssignment	Method contains a pointless self-assignment to a variable or property.
129	UnnecessarySemicolon	Semicolons as line terminators are not required in Groovy: remove them. Do not use a semicolon as a replacement for empty braces on for and while loops; this is a confusing practice.
130	UnnecessarySetter	Checks for explicit calls to setter methods which can, for the most part, be replaced by assignment to property. A setter is defined as a method call that matches set[A-Z] but not set[A-Z][A-Z] such as setURL(). Setters take one method argument.
131	UnnecessaryStringInstantiation	Use a String literal (e.g., "...") instead of calling the corresponding String constructor (new String("..")) directly.
132	UnnecessaryTernaryExpression	Checks for ternary expressions where the conditional expression always evaluates to a boolean and the true and false expressions are merely returning true and false constants. Also checks for ternary expressions where both expressions are the same constant or variable.
133	UnnecessaryToString	Checks for unnecessary calls to toString().
134	UnnecessaryTransientModifier	The field is marked as transient, but the class isn't Serializable, so marking it as transient has no effect.
135	UnusedImport	Imports for a class that is never referenced within the source file is unnecessary.
136	UseCollectMany	In many case collectMany() yields the same result as collect{}.flatten(). It is easier to understand and more clearly conveys the intent.
137	UseCollectNested	Instead of nested collect{}-calls use collectNested{}

Report title:	Sample Project
Date:	Jan 13, 2024 11:01:22 AM
Generated with:	CodeNarc v3.4.0